ref: Remove performance clear entry calls - #2490
Merged
Merged
Conversation
Contributor
rhcarvalho
suggested changes
Mar 12, 2020
rhcarvalho
left a comment
rhcarvalho
left a comment
Contributor
There was a problem hiding this comment.
We cannot guarantee that 300 is actually an increase. Specially not without looking at the number of entries.
Comment on lines
-606
to
-613
| // The Performance object has a limited buffer size, often 150 entries. At some point the buffer may overflow, in | ||
| // which case we would not be able to use it to create/update spans. Therefore, after we have processed entries to | ||
| // report to Sentry, we clear the buffer in an attempt to allow for more entries to be added in the future. | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Performance | ||
| logger.log('[Tracing] Clearing most performance marks'); | ||
| performance.clearMarks(); | ||
| performance.clearMeasures(); | ||
| performance.clearResourceTimings(); |
HazAT
changed the title
onresourcetimingbufferfull
rhcarvalho
approved these changes
Mar 12, 2020
This was referenced Mar 15, 2020
This was referenced Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User code or other libraries may be using the performance entries, therefore we do not clear entries.
Note: there is a limit on the number of "resource timing" entries, we do not change that, leaving it up to the browser default.